Skip to content

fix(@angular-devkit/build-angular): override already existing assets in compilation #19087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 15, 2020
Merged

fix(@angular-devkit/build-angular): override already existing assets in compilation #19087

merged 1 commit into from
Oct 15, 2020

Conversation

alan-agius4
Copy link
Collaborator

With this change we align the copying of assets between ng build and ng serve. Previously in ng serve already copied assets where not overridden.

More info: https://webpack.js.org/plugins/copy-webpack-plugin/#force

Closes #18787

@google-cla google-cla bot added the cla: yes label Oct 15, 2020
@alan-agius4 alan-agius4 requested a review from clydin October 15, 2020 14:19
@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Oct 15, 2020
…in compilation

With this change we align the copying of assets between `ng build` and `ng serve`. Previously in `ng serve` already copied assets where not overridden.

More info: https://webpack.js.org/plugins/copy-webpack-plugin/#force

Closes #18787
@alan-agius4 alan-agius4 changed the title fix(@angular-devkit/build-angular): overridden already existing assets in compilation fix(@angular-devkit/build-angular): override already existing assets in compilation Oct 15, 2020
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Oct 15, 2020
@alan-agius4 alan-agius4 merged commit 4d2f4ec into angular:master Oct 15, 2020
@alan-agius4 alan-agius4 deleted the webpack-copy-assets branch October 15, 2020 15:17
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No Asset replacement in ng serve
2 participants