Skip to content

fix(@angular-devkit/core): workspace reader spread/rest operator usage with falsy values #17515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 21, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -86,6 +86,13 @@ describe('readJsonWorkpace Parsing', () => {
);
});

it(`doesn't remove falsy values when using the spread operator`, async () => {
const host = createTestHost(representativeFile);
const workspace = await readJsonWorkspace('', host);
const prodConfig = workspace.projects.get('my-app')!.targets.get('build')!.configurations!.production!;
expect({ ...prodConfig }).toEqual(prodConfig);
});

it('parses extensions only into extensions object', async () => {
const host = createTestHost(representativeFile);

Original file line number Diff line number Diff line change
@@ -148,7 +148,7 @@ function create(
const propertyPath = path + '/' + escapeKey(p);
const cacheEntry = cache.get(propertyPath);
if (cacheEntry) {
if (cacheEntry.value) {
if (cacheEntry.value !== undefined) {
return createPropertyDescriptor(cacheEntry.value);
}