Skip to content

build: set minimum Node.js version to 10.13 #15756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2019
Merged

build: set minimum Node.js version to 10.13 #15756

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/packages.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ function loadPackageJson(p: string) {
// Overwrite engines to a common default.
case 'engines':
pkg['engines'] = {
'node': '>= 10.9.0',
'node': '>= 10.13.0',
'npm': '>= 6.11.0',
'pnpm': '>= 3.2.0',
'yarn': '>= 1.13.0',
Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
"url": "https://github.com/angular/angular-cli.git"
},
"engines": {
"node": ">=10.9.0 <13.0.0",
"node": ">=10.13.0 <13.0.0",
"yarn": ">=1.17.3 <2.0.0"
},
"author": "Angular Authors",
Expand Down Expand Up @@ -101,7 +101,7 @@
"@types/karma": "^3.0.2",
"@types/loader-utils": "^1.1.3",
"@types/minimist": "^1.2.0",
"@types/node": "10.9.4",
"@types/node": "10.12.30",
"@types/request": "^2.47.1",
"@types/semver": "^6.0.0",
"@types/webpack": "^4.32.1",
Expand Down
4 changes: 2 additions & 2 deletions packages/angular/cli/bin/ng
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ try {
var version = process.version.substr(1).split('.');
if (Number(version[0]) < 10 || (Number(version[0]) === 10 && Number(version[1]) < 9)) {
process.stderr.write(
'You are running version ' + process.version + ' of Node.js, which is not supported by Angular CLI 8.0+.\n' +
'The official Node.js version that is supported is 10.9 or greater.\n\n' +
'You are running version ' + process.version + ' of Node.js, which is not supported by Angular CLI 9.0+.\n' +
'The official Node.js version that is supported is 10.13.0 or greater.\n\n' +
'Please visit https://nodejs.org/en/ to find instructions on how to update Node.js.\n'
);

Expand Down
2 changes: 1 addition & 1 deletion packages/angular_devkit/benchmark/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"benchmark"
],
"engines": {
"node": ">= 10.9.0",
"node": ">= 10.13.0",
"npm": ">= 6.2.0"
},
"dependencies": {
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1143,10 +1143,10 @@
resolved "https://registry.yarnpkg.com/@types/node/-/node-12.7.8.tgz#cb1bf6800238898bc2ff6ffa5702c3cadd350708"
integrity sha512-FMdVn84tJJdV+xe+53sYiZS4R5yn1mAIxfj+DVoNiQjTYz1+OYmjwEZr1ev9nU0axXwda0QDbYl06QHanRVH3A==

"@types/node@10.9.4":
version "10.9.4"
resolved "https://registry.yarnpkg.com/@types/node/-/node-10.9.4.tgz#0f4cb2dc7c1de6096055357f70179043c33e9897"
integrity sha512-fCHV45gS+m3hH17zgkgADUSi2RR1Vht6wOZ0jyHP8rjiQra9f+mIcgwPQHllmDocYOstIEbKlxbFDYlgrTPYqw==
"@types/node@10.12.30":
version "10.12.30"
resolved "https://registry.yarnpkg.com/@types/node/-/node-10.12.30.tgz#4c2b4f0015f214f8158a347350481322b3b29b2f"
integrity sha512-nsqTN6zUcm9xtdJiM9OvOJ5EF0kOI8f1Zuug27O/rgtxCRJHGqncSWfCMZUP852dCKPsDsYXGvBhxfRjDBkF5Q==

"@types/node@^10.1.0":
version "10.14.19"
Expand Down