Skip to content

fix(@ngtools/webpack): delete all virtual files for styles on change #15144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 25, 2019
Merged

fix(@ngtools/webpack): delete all virtual files for styles on change #15144

merged 1 commit into from
Jul 25, 2019

Conversation

@alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented Jul 22, 2019 •
edited
Loading

Fixes #15143

@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Jul 22, 2019
@alan-agius4 alan-agius4 changed the title fix(@ngtools/webpack): delete all virtual files for file on change fix(@ngtools/webpack): delete all virtual files for styles on change Jul 22, 2019
@alan-agius4 alan-agius4 requested a review from filipesilva July 22, 2019 14:04
filipesilva
filipesilva approved these changes Jul 22, 2019
View reviewed changes
Copy link
Contributor

@filipesilva filipesilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice fix!

@alan-agius4 alan-agius4 mentioned this pull request Jul 22, 2019
Closed
@vikerman vikerman merged commit 6649483 into angular:master Jul 25, 2019
@alan-agius4 alan-agius4 deleted the css-aot-file-change branch July 25, 2019 04:26
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 13, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@filipesilva filipesilva filipesilva approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ng serve --aot not properly compiling changed css

4 participants

@alan-agius4 @filipesilva @vikerman @googlebot