Skip to content

fix(@angular-devkit/architect): architect should use provided registry #14182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2019
Merged

fix(@angular-devkit/architect): architect should use provided registry #14182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion etc/api/angular_devkit/architect/src/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
export declare class Architect {
constructor(_host: ArchitectHost, _registry?: json.schema.SchemaRegistry, additionalJobRegistry?: experimental.jobs.Registry);
constructor(_host: ArchitectHost, registry?: json.schema.SchemaRegistry, additionalJobRegistry?: experimental.jobs.Registry);
has(name: experimental.jobs.JobName): Observable<boolean>;
scheduleBuilder(name: string, options: json.JsonObject, scheduleOptions?: ScheduleOptions): Promise<BuilderRun>;
scheduleTarget(target: Target, overrides?: json.JsonObject, scheduleOptions?: ScheduleOptions): Promise<BuilderRun>;
Expand Down
10 changes: 5 additions & 5 deletions packages/angular_devkit/architect/src/architect.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,23 +311,23 @@ export class Architect {

constructor(
private _host: ArchitectHost,
private _registry: json.schema.SchemaRegistry = new json.schema.CoreSchemaRegistry(),
registry: json.schema.SchemaRegistry = new json.schema.CoreSchemaRegistry(),
additionalJobRegistry?: experimental.jobs.Registry,
) {
const privateArchitectJobRegistry = new experimental.jobs.SimpleJobRegistry();
// Create private jobs.
privateArchitectJobRegistry.register(_getTargetOptionsFactory(_host));
privateArchitectJobRegistry.register(_getBuilderNameForTargetFactory(_host));
privateArchitectJobRegistry.register(_validateOptionsFactory(_host, _registry));
privateArchitectJobRegistry.register(_validateOptionsFactory(_host, registry));

const jobRegistry = new experimental.jobs.FallbackRegistry([
new ArchitectTargetJobRegistry(_host, _registry, this._jobCache, this._infoCache),
new ArchitectBuilderJobRegistry(_host, _registry, this._jobCache, this._infoCache),
new ArchitectTargetJobRegistry(_host, registry, this._jobCache, this._infoCache),
new ArchitectBuilderJobRegistry(_host, registry, this._jobCache, this._infoCache),
privateArchitectJobRegistry,
...(additionalJobRegistry ? [additionalJobRegistry] : []),
] as experimental.jobs.Registry[]);

this._scheduler = new experimental.jobs.SimpleScheduler(jobRegistry, _registry);
this._scheduler = new experimental.jobs.SimpleScheduler(jobRegistry, registry);
}

has(name: experimental.jobs.JobName) {
Expand Down