Partial update of Angular schematics with new workspace rules #14126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clydin
force-pushed
the
workspace-schematics
branch
4 times, most recently
from
b838df0 to
a331b7c
Compare
clydin
force-pushed
the
workspace-schematics
branch
4 times, most recently
from
5bb54d1 to
879a66b
Compare
This avoids massive amounts of name conflicts between a commonly named variable of 'workspace' and the namespace
Library projects support scoped package names as project names.
Internally, the JSON workspace support uses JSON pointers to represent change locations. These need to be escaped to support slashes within a key.
clydin
force-pushed
the
workspace-schematics
branch
from
879a66b to
4970bed
Compare
filipesilva
approved these changes
Apr 15, 2019
| export function updateWorkspace( | ||
| updaterOrWorkspace: workspaces.WorkspaceDefinition | ||
| | ((workspace: workspaces.WorkspaceDefinition) => void | PromiseLike<void>), | ||
| ): Rule { |
There was a problem hiding this comment.
Nit: why do we need the extra signatures above? The arg typing here looks ok.
There was a problem hiding this comment.
cleaner in an IDE and allows for eventual separate jsdoc comments tailored to each overload. The second form may also gain a read options parameter at a later time.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds initial infrastructure, fixes several bugs, and updates several of the Angular schematics. Each schematic update is in a separate commit. Tests needed to be updated to use the async version of the test runner but are otherwise unmodified.