-
Notifications
You must be signed in to change notification settings - Fork 12k
docs: add breaking changes to changelog #14020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@alan-agius4 can you add a sample of the generated output here please? |
This comment has been minimized.
This comment has been minimized.
Commits
Breaking Changes@angular-devkit/build-angular: use `sass` instead of `node-sass` (ce15899)we no longer use `node-sass` by default, instead we use `sass` (dart-sass).While in most cases this should not have an impact the generated code, dart sass has some differences from Ruby Sass. See https://github.com/sass/dart-sass#behavioral-differences-from-ruby-sass If you wish to use npm users
yarn users
Note: for larger Sass projects to avoid this performance hit you might want to install Ref: TOOL-748 Special ThanksHans Larsen, Alan Agius, Charles Lyding, Will, Filipe Silva, Keen Yee Liau, Cédric Exbrayat, Renovate Bot, Alex Eagle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sample you pasted above seems to have the BREAKING CHANGE:
text removed. It should remain in the text because it is not obvious where it was before being removed.
Other than that LGTM, great work!
@filipesilva the breaking change is the entire description, in the body there is only the breaking change text. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
No description provided.