Skip to content

docs: add breaking changes to changelog #14020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 29, 2019
Merged

docs: add breaking changes to changelog #14020

merged 1 commit into from
Mar 29, 2019

Conversation

alan-agius4
Copy link
Collaborator

No description provided.

@alan-agius4 alan-agius4 added the target: major This PR is targeted for the next major release label Mar 29, 2019
@alan-agius4 alan-agius4 requested a review from filipesilva March 29, 2019 06:30
@filipesilva
Copy link
Contributor

@alan-agius4 can you add a sample of the generated output here please?

@alan-agius4

This comment has been minimized.

@alan-agius4
Copy link
Collaborator Author

Commits

@angular/cli (8.0.0-beta.9+5.b72bd31.with-local-changes)

Commit Description Notes
add custom implementation for analytics for commands
add support for analytics command proper
add prompt on post install step
add analytic support to commands and command-runner
add universal-analytics as dependency

@schematics/angular (8.0.0-beta.9+5.b72bd31.with-local-changes)

Commit Description Notes
add type checking for protractor.conf.js file [Closes #13958]
use more codelyzer rules
remove baseUrl from universal tsconfig [Closes #13935]

@angular-devkit/build-angular (0.800.0-beta.9+5.b72bd31.with-local-changes)

Commit Description Notes
implement stable architect API for karma
use `sass` instead of `node-sass`
add Server Builder v2
enable webpack profile when using stats-json flag [Closes #13907]
implement stable architect API for protractor
deprecate `profile` option in build
update speed-measure-webpack-plugin to 1.3.1 [Closes #12763]
passing port 0 when using serve will not find a suitable port

@angular-devkit/build-ng-packagr (0.800.0-beta.9+5.b72bd31.with-local-changes)

Commit Description Notes
implement stable architect API

@angular-devkit/build-webpack (0.800.0-beta.9+5.b72bd31.with-local-changes)

Commit Description Notes
report emitted files

@angular-devkit/schematics (8.0.0-beta.9+5.b72bd31.with-local-changes)

Commit Description Notes
add support for analytics

@ngtools/webpack (8.0.0-beta.9+5.b72bd31.with-local-changes)

Commit Description Notes
support Angular 8

Breaking Changes

@angular-devkit/build-angular: use `sass` instead of `node-sass` (ce15899)

we no longer use `node-sass` by default, instead we use `sass` (dart-sass).

While in most cases this should not have an impact the generated code, dart sass has some differences from Ruby Sass. See https://github.com/sass/dart-sass#behavioral-differences-from-ruby-sass
for more details

If you wish to use node-sass instead of sass you need to install node-sass as a dev dependency.

npm users

npm install node-sass --save-dev

yarn users

yarn add node-sass --dev

Note: for larger Sass projects to avoid this performance hit you might want to install fibers. See: https://www.npmjs.com/package/fibers

Ref: TOOL-748


Special Thanks

Hans Larsen, Alan Agius, Charles Lyding, Will, Filipe Silva, Keen Yee Liau, Cédric Exbrayat, Renovate Bot, Alex Eagle

Copy link
Contributor

@filipesilva filipesilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sample you pasted above seems to have the BREAKING CHANGE: text removed. It should remain in the text because it is not obvious where it was before being removed.

Other than that LGTM, great work!

@alan-agius4
Copy link
Collaborator Author

alan-agius4 commented Mar 29, 2019

@filipesilva the breaking change is the entire description, in the body there is only the breaking change text.

@mgechev mgechev merged commit ee337c0 into angular:master Mar 29, 2019
@alan-agius4 alan-agius4 deleted the changelog-breaking-change branch March 30, 2019 06:18
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants