Skip to content

Conversation

@jbogarthyde
Copy link
Contributor

@jbogarthyde jbogarthyde commented Oct 8, 2018

This is an initial draft transferring content from google doc draft to JSON sources.
Basic command descriptions and generation schematic options included.
This is to meant to test the git and cli-doc build process as well.

@jbogarthyde jbogarthyde added the area: docs Related to the documentation label Oct 8, 2018
@jenniferfell jenniferfell changed the title WIP: add doc strings for command update doc strings for command reference Oct 9, 2018
@clydin clydin added the target: major This PR is targeted for the next major release label Oct 10, 2018
@jbogarthyde jbogarthyde requested a review from clydin October 10, 2018 17:57
@jbogarthyde jbogarthyde changed the title update doc strings for command reference Update doc strings for command reference Oct 10, 2018
"description": "Opens the official Angular API documentation for a given keyword.",
"$longDescription": "",
"description": "Opens the Angular documentation in a browser, with a search for a given term.",
"$longDescription": "./doc.md,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing end quote

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved long desc back into short desc

"description": "Generates and/or modifies files based on a schematic.",
"$longDescription": "",
"description": "Creates, initializes, and modifies files to create a generic version of an app or app element in the given or default project, according to the given schematic.",
"$longDescription": "Takes the name of the project, as specified in the \"projects\" section of the angular.json workspace configuration file. \n When a project name is not supplied, the configured default project of the workspace is used.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The generate command actually doesn't take the name of a project in the same way as the other commands. It is currently an outlier and we've been discussing the best path forward to potentially remedy the situation.

Copy link
Member

@clydin clydin Oct 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$longDescription also needs to point to a separate file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No long description now.
I'm also trying to formulate better boilerplate for the ones that do take an optional project. Maybe we can add it to definitions.json

@vikerman vikerman merged commit f48a163 into angular:master Oct 10, 2018
@jbogarthyde jbogarthyde deleted the jb-cli-ref branch October 10, 2018 22:11
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area: docs Related to the documentation target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants