Skip to content

feat(@angular-devkit/build-angular): add ignore option to assets #11868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 6, 2018
Merged

feat(@angular-devkit/build-angular): add ignore option to assets #11868

merged 2 commits into from
Sep 6, 2018

Conversation

alan-agius4
Copy link
Collaborator

add ignore option to assets object

You can now provide an array of globs to ignore from copying.

Closes #11850

@clydin clydin added the needs: discussion On the agenda for team meeting to determine next steps label Aug 27, 2018
@alexeagle alexeagle added the target: major This PR is targeted for the next major release label Aug 30, 2018
@alexeagle
Copy link
Contributor

SGTM
Let's make sure we actually match node-glob semantics (actually minimatch)
Consider expanding the docs with an example showing all the affordances to make it less confusing, and say "if you think you need to exclude files, consider not putting that thing in the assets".

@alexeagle alexeagle removed the needs: discussion On the agenda for team meeting to determine next steps label Aug 30, 2018
@alan-agius4
Copy link
Collaborator Author

@alexeagle docs updated

…object

You can now provide an array of globs to `ignore` from copying

Closes #11850
filipesilva
filipesilva previously approved these changes Aug 31, 2018
`glob` is the a [node-glob](https://github.com/isaacs/node-glob) using `input` as base directory.
`input` is relative to the workspace root, while `output` is relative to `outDir`
(`dist/project-name` default).
- `glob` is the a [node-glob](https://github.com/isaacs/node-glob) using `input` as base directory.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: is the a -> is a

@googlebot
Copy link

☹️ Sorry, but only Googlers may change the label cla: yes.

…object

You can now provide an array of globs to `ignore` from copying

Closes #11850
@alexeagle alexeagle merged commit 01beb52 into angular:master Sep 6, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support glob options in assetPattern
5 participants