Skip to content

fix: remove vendorSourceMap warning that vendorSourceMap is not a… #11732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 2, 2018
Merged

fix: remove vendorSourceMap warning that vendorSourceMap is not a… #11732

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dfccc77
fix(@angular/cli): remove `vendorSourceMap` warning that `vendorSourc…
alan-agius4 Aug 1, 2018
1b4841b
fix(@angular-devkit/build-angular): `--vendor-source-map` doesn't wor…
alan-agius4 Aug 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion docs/documentation/serve.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,15 @@ ng serve [project]
Output in-file eval sourcemaps.
</p>
</details>
<details>
<summary>vendor-source-map</summary>
<p>
<code>--vendor-source-map</code>
</p>
<p>
Resolve vendor packages sourcemaps.
</p>
</details>
<details>
<summary>vendor-chunk</summary>
<p>
Expand Down Expand Up @@ -261,4 +270,4 @@ ng serve [project]
<p>
Log progress to the console while building.
</p>
</details>
</details>
15 changes: 15 additions & 0 deletions packages/angular/cli/lib/config/schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -605,6 +605,11 @@
"description": "Output sourcemaps.",
Copy link
Collaborator Author

@alan-agius4 alan-agius4 Aug 1, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently, this is also required apart from the schema of the specific architect builder.

"default": true
},
"vendorSourceMap": {
"type": "boolean",
"description": "Resolve vendor packages sourcemaps.",
"default": false
},
"evalSourceMap": {
"type": "boolean",
"description": "Output in-file eval sourcemaps.",
Expand Down Expand Up @@ -1000,6 +1005,11 @@
"type": "boolean",
"description": "Output sourcemaps."
},
"vendorSourceMap": {
"type": "boolean",
"description": "Resolve vendor packages sourcemaps.",
"default": false
},
"evalSourceMap": {
"type": "boolean",
"description": "Output in-file eval sourcemaps."
Expand Down Expand Up @@ -1383,6 +1393,11 @@
"description": "Output sourcemaps.",
"default": true
},
"vendorSourceMap": {
"type": "boolean",
"description": "Resolve vendor packages sourcemaps.",
"default": false
},
"evalSourceMap": {
"type": "boolean",
"description": "Output in-file eval sourcemaps.",
Expand Down
3 changes: 3 additions & 0 deletions packages/angular_devkit/build_angular/src/dev-server/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ export interface DevServerBuilderOptions {
optimization?: boolean;
aot?: boolean;
sourceMap?: boolean;
vendorSourceMap?: boolean;
evalSourceMap?: boolean;
vendorChunk?: boolean;
commonChunk?: boolean;
Expand Down Expand Up @@ -399,6 +400,8 @@ export class DevServerBuilder implements Builder<DevServerBuilderOptions> {
...(options.optimization !== undefined ? { optimization: options.optimization } : {}),
...(options.aot !== undefined ? { aot: options.aot } : {}),
...(options.sourceMap !== undefined ? { sourceMap: options.sourceMap } : {}),
...(options.vendorSourceMap !== undefined ?
{ vendorSourceMap: options.vendorSourceMap } : {}),
...(options.evalSourceMap !== undefined ? { evalSourceMap: options.evalSourceMap } : {}),
...(options.vendorChunk !== undefined ? { vendorChunk: options.vendorChunk } : {}),
...(options.commonChunk !== undefined ? { commonChunk: options.commonChunk } : {}),
Expand Down