refactor(@angular-devkit/build-angular): mute internal reporters

[corinna000]

when other reporters are configured

internal Karma reporters should suppress output when user-defined
reporters are configured to prevent extrananeous error reporting for
failed tests (from ng test)

[googlebot]

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

[corinna000]

Not sure how to fix the CLA issue since I used a different gmail account for the commit than I used to sign the CLA. Any tips?

[corinna000]

I guess I could:

1. decline this pr
2. make my changes to a brand new branch, verifying I have the right email configured in my git config
3. resubmit

But I'll wait for a little guidance because I suspect this has happened before.

[clydin]

If you drop the first commit and squash the other two, the CLA check should be fine.

[googlebot]

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

[filipesilva]

Great work on addressing this problem!

Also this is related to #11628

[shairez]

Funny, that's the same PR as mine from the past -
#9529

I wonder what caused the regression there...

[corinna000]

Sorry, @shairez ! Good developers copy, great developers steal. =)

[shairez]

LOL 😄

Pay attention though, that in these lines:

function muteDuplicateReporterLogging(context: any, config: any) {
  context.writeCommonMsg = function () { };
  const reporterName = '@angular/cli';
  const hasTrailingReporters = config.reporters.slice(-1).pop() !== reporterName;
   if (hasTrailingReporters) {
    context.writeCommonMsg = function () { };
  }
}

The first context.writeCommonMsg = function () { }; makes the rest pretty much useless.

It was meant to be "if the last reporter is the angular CLI one, remove the duplication"

So @filipesilva make sure you test it thoroughly and if it works with several different reporters, then you could remove the lines followed by context.writeCommonMsg = function () { };

If not, remove the first statement and change the reporter's name if it has changed.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}