-
Notifications
You must be signed in to change notification settings - Fork 12k
ng eject uses hardcoded project root #9335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
hansl
added a commit
to hansl/angular-cli
that referenced
this issue
Jan 24, 2018
In favor of process.cwd(). Also added a new eject e2e test that verifies the webpack.config.js does NOT have the project path in it at any place. Fixed angular#9335.
hansl
added a commit
that referenced
this issue
Jan 24, 2018
In favor of process.cwd(). Also added a new eject e2e test that verifies the webpack.config.js does NOT have the project path in it at any place. Fixed #9335.
Thanks for fixing @hansl! |
hansl
added a commit
that referenced
this issue
Jan 25, 2018
In favor of process.cwd(). Also added a new eject e2e test that verifies the webpack.config.js does NOT have the project path in it at any place. Fixed #9335.
If I may, this fix only affects the project root. All other paths in the Webpack configuration are still hardcoded. |
dond2clouds
pushed a commit
to d2clouds/speedray-cli
that referenced
this issue
Apr 23, 2018
In favor of process.cwd(). Also added a new eject e2e test that verifies the webpack.config.js does NOT have the project path in it at any place. Fixed angular#9335.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Versions
Repro steps
Observed behavior
Open
webpack.config.js
and search for theprojectRoot
variable (line 25 on Angular-CLI@1.6.5). The value is a hardcoded string which is the path on the computer which ejected the project. In my case/Users/sam/Projects/myproject
. Not only theprojectRoot
is hardcoded, also the glob patterns in theCopyWebpackPlugin
andCircularDependencyPlugin
are hardcoded.Desired behavior
The
projectRoot
should be set to__dirname
and should be reused in the plugins.Mention any other details that might be useful (optional)
The text was updated successfully, but these errors were encountered: