ng build Module not found: Error: Recursion in resolving

[matteobruni]

🐞 Bug report

Command (mark with an x)

• new
• build
• serve
• test
• e2e
• generate
• add
• update
• lint
• xi18n
• run
• config
• help
• version
• doc

Is this a regression?

In Angular 9.x it the command was working fine

Description

Build broken in Angular 10.x

🔬 Minimal Reproduction

Project demo/angular here https://github.com/matteobruni/tsparticles/tree/dev/demo/angular, if you run yarn build:disabled you get the error (the script has :disabled for CI)

🔥 Exception or Error

0% compiling
Compiling @angular/core : es2015 as esm2015

Compiling @angular/common : es2015 as esm2015

Compiling @angular/platform-browser : es2015 as esm2015

Compiling @angular/platform-browser-dynamic : es2015 as esm2015

ERROR in ./src/app/app.module.ts
Module not found: Error: Recursion in resolving
Stack:
  resolve: (/Users/matteo/Projects/GitHub Projects/tsparticles/demo/angular/src/app) ng-particles/dist/ng-particles
  newResolve: (/Users/matteo/Projects/GitHub Projects/tsparticles/demo/angular/src/app) ng-particles/dist/ng-particles
  parsedResolve: (/Users/matteo/Projects/GitHub Projects/tsparticles/demo/angular/src/app) ng-particles/dist/ng-particles module
  describedResolve: (/Users/matteo/Projects/GitHub Projects/tsparticles/demo/angular/src/app) ng-particles/dist/ng-particles module
  rawModule: (/Users/matteo/Projects/GitHub Projects/tsparticles/demo/angular/src/app) ng-particles/dist/ng-particles
  module: (/Users/matteo/Projects/GitHub Projects/tsparticles/demo/angular/src/app) ng-particles/dist/ng-particles
  resolve: (/Users/matteo/Projects/GitHub Projects/tsparticles/node_modules) ./ng-particles/dist/ng-particles
  newResolve: (/Users/matteo/Projects/GitHub Projects/tsparticles/node_modules) ./ng-particles/dist/ng-particles
  parsedResolve: (/Users/matteo/Projects/GitHub Projects/tsparticles/node_modules) ./ng-particles/dist/ng-particles
  describedResolve: (/Users/matteo/Projects/GitHub Projects/tsparticles/node_modules) ./ng-particles/dist/ng-particles
  relative: (/Users/matteo/Projects/GitHub Projects/tsparticles/node_modules/ng-particles/dist/ng-particles) 
  describedRelative: (/Users/matteo/Projects/GitHub Projects/tsparticles/node_modules/ng-particles/dist/ng-particles) 
  rawFile: (/Users/matteo/Projects/GitHub Projects/tsparticles/node_modules/ng-particles/dist/ng-particles) 
  file: (/Users/matteo/Projects/GitHub Projects/tsparticles/node_modules/ng-particles/dist/ng-particles) 
  relative: (/Users/matteo/Projects/GitHub Projects/tsparticles/wrappers/angular/dist/ng-particles) 
  describedRelative: (/Users/matteo/Projects/GitHub Projects/tsparticles/wrappers/angular/dist/ng-particles) 
 @ ./src/app/app.module.ts 4:0-67 12:12-29 15:8-25 24:20-37
 @ ./src/main.ts
 @ multi ./src/main.ts
ERROR in ./src/app/app.component.ts
Module not found: Error: Recursion in resolving
Stack:
  resolve: (/Users/matteo/Projects/GitHub Projects/tsparticles/demo/angular/src/app) ng-particles/dist/ng-particles
  newResolve: (/Users/matteo/Projects/GitHub Projects/tsparticles/demo/angular/src/app) ng-particles/dist/ng-particles
  parsedResolve: (/Users/matteo/Projects/GitHub Projects/tsparticles/demo/angular/src/app) ng-particles/dist/ng-particles module
  describedResolve: (/Users/matteo/Projects/GitHub Projects/tsparticles/demo/angular/src/app) ng-particles/dist/ng-particles module
  rawModule: (/Users/matteo/Projects/GitHub Projects/tsparticles/demo/angular/src/app) ng-particles/dist/ng-particles
  module: (/Users/matteo/Projects/GitHub Projects/tsparticles/demo/angular/src/app) ng-particles/dist/ng-particles
  resolve: (/Users/matteo/Projects/GitHub Projects/tsparticles/node_modules) ./ng-particles/dist/ng-particles
  newResolve: (/Users/matteo/Projects/GitHub Projects/tsparticles/node_modules) ./ng-particles/dist/ng-particles
  parsedResolve: (/Users/matteo/Projects/GitHub Projects/tsparticles/node_modules) ./ng-particles/dist/ng-particles
  describedResolve: (/Users/matteo/Projects/GitHub Projects/tsparticles/node_modules) ./ng-particles/dist/ng-particles
  relative: (/Users/matteo/Projects/GitHub Projects/tsparticles/node_modules/ng-particles/dist/ng-particles) 
  describedRelative: (/Users/matteo/Projects/GitHub Projects/tsparticles/node_modules/ng-particles/dist/ng-particles) 
  rawFile: (/Users/matteo/Projects/GitHub Projects/tsparticles/node_modules/ng-particles/dist/ng-particles) 
  file: (/Users/matteo/Projects/GitHub Projects/tsparticles/node_modules/ng-particles/dist/ng-particles) 
  relative: (/Users/matteo/Projects/GitHub Projects/tsparticles/wrappers/angular/dist/ng-particles) 
  describedRelative: (/Users/matteo/Projects/GitHub Projects/tsparticles/wrappers/angular/dist/ng-particles) 
 @ ./src/app/app.component.ts 3:0-53 360:22-45
 @ ./src/app/app.module.ts
 @ ./src/main.ts
 @ multi ./src/main.ts
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

🌍 Your Environment

     _                      _                 ____ _     ___
    / \   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|
   / △ \ | '_ \ / _` | | | | |/ _` | '__|   | |   | |    | |
  / ___ \| | | | (_| | |_| | | (_| | |      | |___| |___ | |
 /_/   \_\_| |_|\__, |\__,_|_|\__,_|_|       \____|_____|___|
                |___/
    

Angular CLI: 10.0.0
Node: 12.17.0
OS: darwin x64

Angular: 10.0.0
... animations, cli, common, compiler, compiler-cli, core, forms
... platform-browser, platform-browser-dynamic, router
Ivy Workspace: 

Package                            Version
------------------------------------------------------------
@angular-devkit/architect          0.1000.0
@angular-devkit/build-angular      0.1000.0
@angular-devkit/build-ng-packagr   0.1000.0
@angular-devkit/build-optimizer    0.1000.0
@angular-devkit/build-webpack      0.1000.0
@angular-devkit/core               10.0.0
@angular-devkit/schematics         10.0.0
@ngtools/webpack                   10.0.0
@schematics/angular                10.0.0
@schematics/update                 0.1000.0
ng-packagr                         10.0.0
rxjs                               6.5.5
typescript                         3.9.5
webpack                            4.43.0

Anything else relevant?

[alan-agius4]

Hi @matteobruni,

I am unable to replicate the above error with the provided steps.

I encountered this following error

ERROR in src/app/app.module.ts:5:35 - error TS2307: Cannot find module 'ng-particles/dist/ng-particles' or its corresponding type declarations.

5 import { NgParticlesModule } from 'ng-particles/dist/ng-particles';

Which seems to be related to one of the imports.
https://github.com/matteobruni/tsparticles/blob/31cdc2ad3e54c70bf5710a1a250404e78f50b402/demo/angular/src/app/app.module.ts#L5

Which should be replaced with

import { NgParticlesModule } from 'ng-particles';

[matteobruni]

Hi @alan-agius4

Sorry I forgot some steps to be done in the root folder

yarn install && lerna bootstrap && lerna run build

This should build the library for the demo project. The path is correct with the list folder for a workaround with the lerna package management

EDIT: I don't know if the Angular wrapper has issues, the build completes without warnings. You can find it in wrappers/angular folder if you need more info

[slubowsky]

I get same issue updating from 9 to 10. Works fine in 9 fails in 10 with error

ERROR in ./src/app/app.module.ts
Module not found: Error: Recursion in resolving
...

Package causing problem is a local package referenced in package.json using file - https://docs.npmjs.com/files/package.json#local-paths