Skip to content

Remove legacy guessing logic from app-shell #16353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wagnermaciel opened this issue Dec 4, 2019 · 1 comment · Fixed by #19173
Closed

Remove legacy guessing logic from app-shell #16353

wagnermaciel opened this issue Dec 4, 2019 · 1 comment · Fixed by #19173
Labels
area: @angular-devkit/build-angular feature Issue that requests a new feature
Milestone

Comments

@wagnermaciel
Copy link
Contributor

Currently _getServerModuleBundlePath of app-shell/index.ts uses a regular expression to try to find the main bundle file.

https://github.com/angular/angular-cli/blob/master/packages/angular_devkit/build_angular/src/app-shell/index.ts#L111

This is unnecessary since the main bundle will always be named main.js

@alan-agius4 I noticed this issue as a result of your comment that revealed this guessing logic is no longer needed

angular/universal#1357 (comment)

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: @angular-devkit/build-angular feature Issue that requests a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants