run-module-worker.js doesn't check message.hash correctly (bad 'if' compare)

[scovetta]

Bug Report or Feature Request (mark with an x)

- [X] bug report -> please search issues before submitting
- [ ] feature request

Command (mark with an x)

- [ ] new
- [X] build
- [ ] serve
- [ ] test
- [ ] e2e
- [ ] generate
- [ ] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Versions

master

Repro steps

The file packages/angular_devkit/build_angular/src/utils/run-module-worker.js contains a bug in an if statement -- this will always evaluate to 'true':

  if (message.hash = '5d4b9a5c0a4e0f9977598437b0e85bcc') {

I believe this is intended to be either == or ===:

  if (message.hash == '5d4b9a5c0a4e0f9977598437b0e85bcc') {

The log given by the failure

n/a

Desired functionality

n/a

Mention any other details that might be useful

This was found through static analysis.

[alexeagle]

Root cause here is that we aren't running the right static analysis. We should make this a compiler error in http://tsetse.info I think.

[clydin]

There's a tslint rule that covers that: no-conditional-assignment. The rule is currently not used (PR in progress to fix that). The file is also a Javascript file which are not currently linted.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}