ng build --prod should suppress warnings about circular dependencies in ngfactory.js files

[fr0]

Bug Report or Feature Request (mark with an x)

- [X] bug report -> please search issues before submitting
- [ ] feature request

Area

- [ ] devkit
- [ ] schematics

Versions

Angular CLI: 6.0.8
Node: 8.9.4
OS: darwin x64
Angular: 6.0.4
... animations, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, router

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.6.8
@angular-devkit/build-angular     0.6.8
@angular-devkit/build-optimizer   0.6.8
@angular-devkit/core              0.6.8
@angular-devkit/schematics        0.6.8
@angular/cli                      6.0.8
@ngtools/webpack                  6.0.8
@schematics/angular               0.6.8
@schematics/update                0.6.8
rxjs                              6.2.0
typescript                        2.7.2
webpack                           4.8.3

Repro steps

See attached repo. Run yarn install or npm install, then run ng build --prod.

The log given by the failure

WARNING in Circular dependency detected:
src/app/bar.component.ngfactory.js -> src/app/foo.component.ngfactory.js -> src/app/bar.component.ngfactory.js

WARNING in Circular dependency detected:
src/app/foo.component.ngfactory.js -> src/app/bar.component.ngfactory.js -> src/app/foo.component.ngfactory.js

Desired functionality

No warnings should be printed.

Mention any other details that might be useful

Having mutually recursive components is a very useful thing to do. The warnings about circular dependencies in the ngfactory.js files (which are only produced when using AoT) is just noise, and the CircularDependencyPlugin config should filter them out.

angular-cli-test.zip

[filipesilva]

Yeah I agree. We can probably configure the plugin we use to ignore the factories.

Would you be interested in making a PR? It should be fairly straightforward here https://github.com/angular/angular-cli/blob/master/packages/angular_devkit/build_angular/src/angular-cli-files/models/webpack-configs/common.ts#L151-L155

[fr0]

I'll gladly submit a PR! It might be early next week by the time I get to it. Thanks for the response!

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}