nulling the reference to the activity in onDetach to avoid leaks #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Nice gotcha @demoritas. By the way I think that this can be resolved with this lib also https://github.com/trello/RxLifecycle |
|
Actually I am not sure. |
|
|
|
|
|
maybe I'm calling RX wrong or made another error (I'm fairly new to RX) also leakcanary does not show a leak which is strange since the activity does show up in the debugger. |
|
I added this line manually since I was solving all the fixes. Closing the PR and thanks again for the contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a Fragment is detached all references to the detaching activity should be removed, this PR sets the userListListener of the UserListFragment to null in onDetach()