Use @inject-annotated constructor for navigator #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vtuan10 Can you squash this into 1 commit so I merge it? |
no need to use @provides for navigator since Dagger 2 can construct it by @inject-annotated constructor
|
@android10 Done. |
android10
added a commit
that referenced
this pull request
Jan 20, 2016
Use @inject-annotated constructor for navigator
|
@vtuan10 great! Thanks for the collaboration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Navigator can be constructed by the @inject-annotated constructor, there is no need to provide it in a module. @provide-annotations should only be used for interfaces, third-party classes or objects which have to be configured. None of these apply here.