Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update gradles to make the build pass on Android Studio 3.0 #252

Merged
merged 3 commits into from
Dec 28, 2020
Merged

update gradles to make the build pass on Android Studio 3.0 #252

merged 3 commits into from
Dec 28, 2020

Conversation

LiLister
Copy link

I updated some build.gradle files to make the project synced and built successfully.
Android Studio 3.0 changed the default gradle tool version. and the gradle update introduces some new syntax for build.gradle.

@CoderSpinoza
Copy link

Seems license agreement is needed for CI to pass. I suppose the below link recommends the easiest solution.

https://stackoverflow.com/a/45782695/1509425

Just running

yes | sdkmanager --licenses

before

./gradlew build

When can this be merged?

@l3d00m
Copy link

l3d00m commented Feb 4, 2018

@CoderSpinoza I think travis does it automatically if the .travis.yaml file is updated with the new build tools version, this is missing here

@LiLister
Copy link
Author

The .travis.yml has been updated according to update of dependencies.gradle.

@soshial
Copy link

soshial commented Dec 26, 2020

@LiLister , thank you so much for fixing this! It even works in Android Studio 4.1.1
I spend 2 hours trying to do it myself before giving up and using your PR.

Copy link
Owner

@android10 android10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 thanks for the contribution.

@android10
Copy link
Owner

@LiLister merging right away! @soshial sorry for the radio silence. Sometimes it is hard to get time to attend many requests, plus this codebase was less maintained due to the efforts being put on the kotlin side of things.

In any case, super happy to see people active here. I totally appreciate it! ❤️

One more time, thank you!

@android10 android10 merged commit 8ed4222 into android10:master Dec 28, 2020
@LiLister LiLister deleted the update-project branch January 2, 2021 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants