WIP: Upgrade to gradle android build tool 3.0 #248
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adikari
changed the title
|
Travis seems to be failing due to license acceptance. I will update travis config if this PR gets interest of author. |
piotrek1543
reviewed
Nov 11, 2017
| androidTargetSdkVersion = 21 | ||
| androidCompileSdkVersion = 21 | ||
| androidTargetSdkVersion = 25 | ||
| androidCompileSdkVersion = 25 |
There was a problem hiding this comment.
I would change them to 26 to be more consistent.
I think that there were used 21(much lower to build tools version) just to do not need to implement Android permission runtime for release version of app.
piotrek1543
reviewed
Nov 11, 2017
| distributionBase=GRADLE_USER_HOME | ||
| distributionPath=wrapper/dists | ||
| zipStoreBase=GRADLE_USER_HOME | ||
| zipStorePath=wrapper/dists | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-2.10-bin.zip | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-4.2.1-bin.zip |
|
@adikari you changed tools version in Gradle, but you forgot to change it in CI config (which is a common mistake in PR like this). (As you already noticed) that's why Travis task fails. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.