Skip to content

Bug/57553 resolve conflicts #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
51 commits
Select commit Hold shift + click to select a range
2e4f2c7
Include non-enumerable keys in __importStar helper (#60262)
rbuckton Oct 18, 2024
c07da58
Disallow type and interface declarations in statements with blockless…
Andarist Oct 18, 2024
df9d165
fix(59463): Feature that displays method argument names inline does n…
a-tarasyuk Oct 18, 2024
e6ef279
Fix template string escaping (#60303)
rbuckton Oct 21, 2024
d9eeeae
Bump github/codeql-action from 3.26.12 to 3.26.13 in the github-actio…
dependabot[bot] Oct 21, 2024
aa411ac
Add a test for constraint of an infer type parameter not being fully …
Andarist Oct 21, 2024
e25abe3
Error on too many parameters for iterator method (#60321)
rbuckton Oct 22, 2024
241a6c9
fix(55168): Computed properties do not respect setter signatures (#55…
a-tarasyuk Oct 22, 2024
a62ac67
fix(59779): The semicolons: "remove" formatting option doesn't remove…
a-tarasyuk Oct 22, 2024
1679f44
More rigorous ASI prevention when emitting `return`/`yield` (#60304)
rbuckton Oct 22, 2024
437d7f7
Fixed crash in auto import suggestions for `default` of exported UMD …
Andarist Oct 23, 2024
6a90111
Fixed "add missing properties" codefix for positions with nullable co…
Andarist Oct 23, 2024
db8eacd
fix(59397): JsDoc is missing/duplicated in declarations for overloads…
a-tarasyuk Oct 23, 2024
2ac4cb7
Fix prioritization of `paths` specifiers over node_modules package sp…
andrewbranch Oct 23, 2024
6beca69
Bump the github-actions group with 4 updates (#60356)
dependabot[bot] Oct 28, 2024
cb44488
Fixed a JSDoc-related crash when obtaining type of a type literal typ…
Andarist Oct 28, 2024
2161893
fix paste edits range: include all completely selected identifiers (#…
iisaduan Oct 29, 2024
da15ef2
Fix a crash in an anonymous buffer that copilot is writing to. (#60377)
sandersn Oct 30, 2024
f478257
Remove unused `SymbolLinks["bindingElement"]` (#60385)
Andarist Oct 31, 2024
a271797
Use `canHaveFlowNode` in `checkIfExpressionRefinesParameter` (#58816)
Andarist Oct 31, 2024
48f2ada
Add string literal completions for `package.json` `imports` field (#5…
Andarist Oct 31, 2024
e4dc78a
Fixed crash on class member completions with auto imports from merged…
Andarist Oct 31, 2024
32513a7
Fixed an accidental `undefined` leak into `getAccessibleSymbolChain`'…
Andarist Oct 31, 2024
3e61718
fix autoimports crash: generate namespace and other module symbol imp…
iisaduan Nov 1, 2024
248c8f5
Fix incorrect details in lib.decorators (#60252)
trusktr Nov 1, 2024
11b2930
Add compatible overloads that accept ArrayBuffer to BigInt64Array/Big…
rbuckton Nov 1, 2024
0ec4d30
Fixing exception on unsaved file (#60362)
navya9singh Nov 3, 2024
c09e2ab
Fixed syntactic nullisness semantics for comma expressions (#60402)
Andarist Nov 4, 2024
131f673
Bump version to 5.8. (#60422)
DanielRosenwasser Nov 5, 2024
82a04b2
Fix false positive rewriteRelativeImportExtensions error on non-TS ex…
andrewbranch Nov 5, 2024
9d7e087
Remove cancellationToken.js (#60250)
jakebailey Nov 5, 2024
80eeb4e
Proposed expandable hover API (#59940)
gabritto Nov 6, 2024
60dd512
fix(60223): add Promise.try() to ESNext lib (#60232)
dirkluijk Nov 6, 2024
8d95ac5
Fix `getEffectiveCheckNode` (#60309)
gabritto Nov 6, 2024
5e2e321
Reuse cached resolved signatures early (#60208)
Andarist Nov 6, 2024
30979c2
Narrow generic conditional and indexed access return types when check…
gabritto Nov 6, 2024
55f1248
MetaProperty is possibly nullish (#60440)
RyanCavanaugh Nov 6, 2024
ef802b1
feat(60312): Add missing properties for satisfies (#60314)
a-tarasyuk Nov 8, 2024
b58ac4a
Extract function types from function and arrow expressions. (#60234)
dragomirtitian Nov 11, 2024
79ea5a5
Stub out copilotRelated command (#60488)
sandersn Nov 13, 2024
c043944
Let isolated declarations fixer add toplevel imports more (#60267)
benjaminjkraft Nov 13, 2024
b3c67d3
Move to file: fix detection of references to globals that shouldn't b…
andrewbranch Nov 15, 2024
d6b7c41
fix(60505): Convert to namespace import refactoring should drop file …
a-tarasyuk Nov 20, 2024
d85767a
fix(60484): Implementing a prim type in a class expression should rep…
a-tarasyuk Nov 20, 2024
ee0e08b
Bump the github-actions group across 1 directory with 2 updates (#60581)
dependabot[bot] Nov 25, 2024
96410eb
fix missing react error with fragments in `react-native` (#60615)
iisaduan Nov 26, 2024
9fe6c36
Fixed syntactic nullisness semantics for tagged template expressions …
Andarist Nov 26, 2024
b263cc4
Improve the definition of atan2() (#60493)
Psychpsyo Nov 27, 2024
9717772
Allow assignments to readonly class properties within IIFEs contained…
Andarist Dec 2, 2024
14c65b3
Check if switch statements are exhaustive when their expressions is g…
Andarist Dec 2, 2024
ac24ab7
Merge remote-tracking branch 'origin/main' into bug/57553-resolve-con…
Andarist Dec 3, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix false positive rewriteRelativeImportExtensions error on non-TS ex…
…tensions (microsoft#60415)
  • Loading branch information
andrewbranch authored Nov 5, 2024
commit 82a04b29b4f60b887c5c548f406d4dbc9462f79b
2 changes: 1 addition & 1 deletion src/compiler/utilities.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4306,7 +4306,7 @@ export function tryGetImportFromModuleSpecifier(node: StringLiteralLike): AnyVal

/** @internal */
export function shouldRewriteModuleSpecifier(specifier: string, compilerOptions: CompilerOptions): boolean {
return !!compilerOptions.rewriteRelativeImportExtensions && pathIsRelative(specifier) && !isDeclarationFileName(specifier);
return !!compilerOptions.rewriteRelativeImportExtensions && pathIsRelative(specifier) && !isDeclarationFileName(specifier) && hasTSFileExtension(specifier);
}

/** @internal */
Expand Down
14 changes: 14 additions & 0 deletions tests/baselines/reference/nonTSExtensions.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
//// [tests/cases/conformance/externalModules/rewriteRelativeImportExtensions/nonTSExtensions.ts] ////

//// [example.json]
{}

//// [styles.d.css.ts]
export {};

//// [index.mts]
import {} from "./example.json" with { type: "json" }; // Ok
import {} from "./styles.css"; // Ok

//// [index.mjs]
export {};
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
// @module: nodenext
// @rewriteRelativeImportExtensions: true
// @allowArbitraryExtensions: true
// @resolveJsonModule: true
// @noTypesAndSymbols: true

// @Filename: example.json
{}

// @Filename: styles.d.css.ts
export {};

// @Filename: index.mts
import {} from "./example.json" with { type: "json" }; // Ok
import {} from "./styles.css"; // Ok