Correct for change in Odoo repository #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- call apt-get less often - make calls to GitHub idempotent - make mkdir calls idempotent - fix missing quote - remove superfluous whitespace modified: odoo-saas4/ubuntu-14-04/odoo_install.sh
- call apt-get less often - make calls to GitHub idempotent - make mkdir calls idempotent - fix missing quote - remove superfluous whitespace modified: odoo-saas4/ubuntu-14-04/odoo_install.sh
Create config files using "here doc" rules, instead of patching &/or appending attributes Put complicated command groups into functions for improved readability. Force running script as root and eliminate all dependence on "sudo" modified: odoo-saas4/ubuntu-14-04/odoo_install.sh
Also: - relocate constants to top - detect presence of openerp-server file to distinguish pull vs clone - don't install unused packages (subversion, bzr, etc.) Changes to be committed: modified: odoo-saas4/ubuntu-14-04/odoo_install.sh
so multiple parallel versions can be kept Changes to be committed: modified: odoo-saas4/ubuntu-14-04/odoo_install.sh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I first tried your script, it failed because Odoo seems to have removed their sample openerp-server-conf file to a different sub-directory.
I noticed you were using sed patching and cat appending to that and other files. In my experience the "here document" is a much more readable and maintainable alternative, so I changed it to do that. Then I found my self wanting to add a few more tricks that make scripts more maintainable &/or less work.
My changes include :
Thanks for providing your script in the first place! It helped me ensure that my understanding of the new file hierarchy in GitHub is correct.