fix(src/prime.go): refactor go codes, optimaze it #17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's seem that go version code is slower than python and js and it didn't make sense for me, so I looked at the code and for some reason if statement inside a loop make the code slower so I rewrite it and move the if statement to for conventional statement. here is the benchmark result I've got for before and after the change:
before:
BenchmarkPrime-8 311378482 3.755 ns/op 0 B/op 0 allocs/op
after:
BenchmarkPrime-8 1000000000 0.3114 ns/op 0 B/op 0 allocs/op
it's like the updated code is 10x faster than the old one.