Fix Logical Error in unfix Method for Reversed State in Bitset #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
你看都没看懂，你改完之后你都不测吗？你看看报不报错？！无语 |
Author
|
嗯嗯 谢谢左老师 我就是这块没想明白 然后又找gpt4求证了一下 它好像也没回答明白 我应该自己再测一下的😭 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses a logical inconsistency in the unfix method of the Bitset class. Previously, the method did not correctly handle the removal of elements in the reversed state (reverse == true). In the reversed state, a bit value of 0 is supposed to represent the existence of an element, whereas 1 represents its absence. However, the existing implementation was incorrectly updating the zeros and ones counters upon removal of an element.