Skip to content

Conversation

@greenLeopard
Copy link

@greenLeopard greenLeopard commented Jul 17, 2024

I've made three small changes to remove the UserWarning without suppressing all warnings (#283 ).

  1. In the constructor, set the default value for delay_after_gen to None.
  2. In the validation step, if the incoming argument is None, set self.delay_after_gen to None.
  3. Before calling time.sleep(self.delay_after_gen) just check whether it's None.

Although, the alternative, since it's being deprecated, is to remove all references to delay_after_gen. I'll be happy to do that if it's your preference, then I'll resubmit the PR.

@ahmedfgad ahmedfgad added the enhancement New feature or request label Jan 7, 2025
@ahmedfgad
Copy link
Owner

Thank you but the delay_after_gen attribute will be removed in the next release!

@ahmedfgad ahmedfgad closed this Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants