[MI-241] Update if statement on getConnectionStatus #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
There was a problem hiding this comment.
Translation will also need to be updated
joseconsador
force-pushed
the
jose/MI-241
branch
from
9213829 to
42fbea3
Compare
There was a problem hiding this comment.
When you need to modify the text, please create a new key and mark this as obsolete:
https://zendesk.atlassian.net/wiki/display/I18N/Editing+strings
|
👍 for strings |
|
👍 |
|
This PR has 2 +1s, so I will merge now so that the string update will get into this week's project. Going forward, please separate the string change into a separate PR so that PR can be merged in advance of the code PR. That way, the translation can be in progress while the code is still being perfected. -Paul |
pdeuter
added a commit
that referenced
this pull request
Sep 18, 2015
[MI-241] Update if statement on getConnectionStatus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds logging when an exception is caught during Zendesk_Zendesk_Model_Api_Abstract::_call() .
Also improves the conditional statement which caused the notice.
Updated the error message as per https://support.zendesk.com/agent/tickets/1134038
/cc @miogalang @jwswj @mmolina @iandjx
References
Risks