Skip to content

[MI-1583] Initialise config set when saving the configuration #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 13, 2017
Merged

[MI-1583] Initialise config set when saving the configuration #132

merged 1 commit into from
Oct 13, 2017

Conversation

samgavinio
Copy link
Contributor

/cc @zendesk/mintegrations

Description

When the web widget is active, this change checks if the config set has already been set and sets it if it isn't.

References

Risks

  • [low] Adds at the most two API calls when saving the config, will add to the total time to save the config.

@samgavinio samgavinio merged commit 3f99f5f into master Oct 13, 2017
@samgavinio samgavinio deleted the samgavinio/MI-1583-set-embeddable-config-if-not-set branch October 13, 2017 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@miogalang miogalang miogalang approved these changes

@kcasas kcasas kcasas approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samgavinio @miogalang @kcasas