[MI-1321] Skip unnecessary api call if no custom ticket field is set. #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samgavinio
changed the title
miogalang
approved these changes
Feb 9, 2017
jmramos02
reviewed
Feb 9, 2017
| public function forOrder($orderIncrementId) | ||
| { | ||
| $fieldId = Mage::getStoreConfig('zendesk/frontend_features/order_field_id'); | ||
| if(! $fieldId) { |
samgavinio
force-pushed
the
samgavinio/MI-1321-order-tickets-bug
branch
from
e03277f to
7dd9877
Compare
|
@jmramos02 💇♂️ |
jmramos02
approved these changes
Feb 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @zendesk/mintegrations
Description
Skips an unnecessary call to the search api for when the
order_field_id configis not set. Whenorder_field_idis not set, the method affected in this PR will return false anyway so might as well not make that API call.Also improves the search API call by making use of the
fieldValuesearch criteria.References
Risks