Cursor component: remove raycaster-closest-entity-changed listener when removing the component #5625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… component, this fixes getIntersection on undefined error when we remove cursor and raycaster components on the scene and there is a hand raycaster emitting this event
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Remove the
raycaster-closest-entity-changedlistener (event introduced in 981cb81) when removing the cursor component.This fixes
getIntersection on undefinederror when we dynamically remove cursor and raycaster components on the scene when entering VR and there is a hand raycaster emitting this event.Changes proposed:
raycaster-closest-entity-changedlistener is added inaddEventListenersbut never removed, remove it inremoveEventListenerslike the other listeners.