Skip to content

Make cursor component work when camera is not an entity like in the inspector #5614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 25, 2024
Merged

Make cursor component work when camera is not an entity like in the inspector #5614

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a793ad5
Make cursor component work when camera is not an entity like in the i…
vincentfretin Nov 25, 2024
35a69dc
Assign cameraElParent and do the world transform only if we have a pose
vincentfretin Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/components/cursor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,7 @@ module.exports.Component = registerComponent('cursor', {
return function (evt) {
var bounds = this.canvasBounds;
var camera = this.el.sceneEl.camera;
var cameraElParent = camera.el.object3D.parent;
var cameraElParent;
var left;
var point;
var top;
Expand Down Expand Up @@ -301,6 +301,7 @@ module.exports.Component = registerComponent('cursor', {
origin.copy(transform.position);

// Transform XRPose into world space
cameraElParent = camera.el.object3D.parent;
cameraElParent.localToWorld(origin);
direction.transformDirection(cameraElParent.matrixWorld);
}
Expand Down
Loading