Skip to content

Make isCompatibleTexture check stricter by requiring equal source #5529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2024
Merged

Make isCompatibleTexture check stricter by requiring equal source #5529

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Make isCompatibleTexture check stricter by requiring equal source
  • Loading branch information
@mrxz
mrxz committed May 29, 2024
commit 6b661035c98330872aa8952c469d8ddca9d36fdc
7 changes: 5 additions & 2 deletions src/utils/material.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,13 +291,16 @@ module.exports.handleTextureEvents = handleTextureEvents;
* @returns {boolean} True if the texture is compatible with the source, false otherwise
*/
function isCompatibleTexture (texture, source) {
if (texture.source !== source) {
return false;
}

if (source.data instanceof HTMLCanvasElement) {
return texture.isCanvasTexture;
}

if (source.data instanceof HTMLVideoElement) {
// VideoTexture can't have its source changed after initial user
return texture.isVideoTexture && texture.source === source;
return texture.isVideoTexture;
}

return texture.isTexture && !texture.isCanvasTexture && !texture.isVideoTexture;
Expand Down