Skip to content

Fix ES usage in node #5522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
May 22, 2024
Merged

Fix ES usage in node #5522

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
dfc9fd9
rename three.module.js to three.mjs
vincentfretin May 20, 2024
c683860
make the imports works in node 22 with --experimental-require-module …
vincentfretin May 20, 2024
97df8c9
stop polyfilling process.browser and modify isBrowserEnvironment check
vincentfretin May 20, 2024
72128b1
make node test running
vincentfretin May 20, 2024
f4506a4
alias super-three to three in package.json so it works on node
vincentfretin May 20, 2024
452956b
window.THREE is set in index.js, no need to do it in lib/three.mjs
vincentfretin May 20, 2024
10dc0d2
we still need process polyfill for the browser tests
vincentfretin May 20, 2024
d599f43
update documentation about jsdom
vincentfretin May 20, 2024
b28c0d7
strip npm:super-three@ when showing the three version in console
vincentfretin May 21, 2024
d26adfd
use a global INSPECTOR_VERSION variable instead of process.env.INSPEC…
vincentfretin May 21, 2024
b9392ec
put back a comment about mocked process in isBrowserEnvironment
vincentfretin May 21, 2024
c910e33
use THREE.REVISION to log three version, when using aframe as ES modu…
vincentfretin May 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
rename three.module.js to three.mjs
  • Loading branch information
@vincentfretin
vincentfretin committed May 20, 2024
commit dfc9fd9b9d714fca0d876db4760d4bd79f7af3f2
0 src/lib/three.module.js → src/lib/three.mjs
View file
Open in desktop
File renamed without changes.