Skip to content

Conversation

@mrxz
Copy link
Contributor

@mrxz mrxz commented Feb 14, 2024

Description:
Setting an unknown property for a system resulted in an incomplete warning message, for example:

core:schema:warn Unknown property `sortObjects` for component/system `undefined`. 

The name of the system wasn't passed along to parseProperties resulting in the name becoming undefined. This PR fixes the properties passed to parseProperties.

Changes proposed:

  • Pass system's name to parseProperties for proper warning messages
  • Pass false instead of undefined for boolean argument getPartialData

@dmarcos
Copy link
Member

dmarcos commented Feb 14, 2024

Thanks!

@dmarcos dmarcos merged commit 58c960e into aframevr:master Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants