Skip to content

Fix bug when checking schema properties for schemaChange #5426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 8, 2024
Merged

Fix bug when checking schema properties for schemaChange #5426

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4bb0c41
Fix bug when checking schema properties for schemaChange
mrxz Jan 7, 2024
2a76f30
Added unit tests for schemaChange properties
mrxz Jan 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Added unit tests for schemaChange properties
  • Loading branch information
@mrxz
mrxz committed Jan 8, 2024
commit 2a76f30de8fe34d986f573694eb602ccdbf0d255
66 changes: 66 additions & 0 deletions tests/core/component.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -543,6 +543,72 @@ suite('Component', function () {
assert.equal(3, el.object3D.position.y);
assert.equal(3, el.object3D.position.z);
});

test('calls updateSchema when initializing component', function () {
let updateSchemaSpy = this.sinon.spy();
registerComponent('dummy', {
schema: {
type: {default: 'plane', schemaChange: true}
},
updateSchema: function () {
updateSchemaSpy();
}
});
el.hasLoaded = true;
el.setAttribute('dummy', {});
assert.ok(updateSchemaSpy.calledOnce);
});

test('updates schema when property with schemaChange is changed', function () {
let updateSchemaSpy = this.sinon.spy();
registerComponent('dummy', {
schema: {
type: {default: 'plane', schemaChange: true},
color: {default: 'blue'}
},
updateSchema: function () {
updateSchemaSpy();
}
});
el.hasLoaded = true;
el.setAttribute('dummy', {});
el.setAttribute('dummy', {type: 'box'});
assert.ok(updateSchemaSpy.calledTwice);
});

test('does not update schema when no property with schemaChange is changed', function () {
let updateSchemaSpy = this.sinon.spy();
registerComponent('dummy', {
schema: {
type: {default: 'plane', schemaChange: true},
color: {default: 'blue'}
},
updateSchema: function () {
updateSchemaSpy();
}
});
el.hasLoaded = true;
el.setAttribute('dummy', {});
el.setAttribute('dummy', {color: 'red'});
assert.ok(updateSchemaSpy.calledOnce);
});

test('ignores invalid properties when checking if schema needs to be updated', function () {
let updateSchemaSpy = this.sinon.spy();
registerComponent('dummy', {
schema: {
type: {default: 'plane', schemaChange: true},
color: {default: 'blue'}
},
updateSchema: function () {
updateSchemaSpy();
}
});
el.hasLoaded = true;
el.setAttribute('dummy', {});
el.setAttribute('dummy', {invalidProperty: 'should be ignored', color: 'red'});
assert.ok(updateSchemaSpy.calledOnce);
});
});

suite('resetProperty', function () {
Expand Down