Skip to content

Set .background null when removing background component #5417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Set .background null when removing background component #5417

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Set .background null when removing background component
  • Loading branch information
@mrxz
mrxz committed Dec 19, 2023
commit 754b8ada8e7c692da0fdd58f71f857a530f48991
8 changes: 1 addition & 7 deletions src/components/scene/background.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
/* global THREE */
var register = require('../../core/component').registerComponent;
var COMPONENTS = require('../../core/component').components;

module.exports.Component = register('background', {
schema: {
Expand All @@ -19,12 +18,7 @@ module.exports.Component = register('background', {
},

remove: function () {
var data = this.data;
var object3D = this.el.object3D;
if (data.transparent) {
object3D.background = null;
return;
}
object3D.background = COMPONENTS[this.name].schema.color.default;
object3D.background = null;
}
});
4 changes: 2 additions & 2 deletions tests/components/scene/background.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,11 @@ suite('background', function () {
assert.shallowDeepEqual(sceneEl.object3D.background, {r: 1, g: 1, b: 0});
});

test('change the background color', function () {
test('remove the background', function () {
var sceneEl = this.sceneEl;
assert.shallowDeepEqual(sceneEl.object3D.background, null);
sceneEl.setAttribute('background', {color: 'yellow'});
sceneEl.removeAttribute('background');
assert.equal(sceneEl.object3D.background, 'black');
assert.equal(sceneEl.object3D.background, null);
});
});