Skip to content

Conversation

@mrxz
Copy link
Contributor

@mrxz mrxz commented Nov 17, 2023

Description:
As reported by @vincentfretin on the aframe-environment-component: supermedium/aframe-environment-component#96

When registering non-raw shaders, a warning would be logged by Three.js indicating that the glslVersion was undefined. This was introduced in #5328 when addressing related changes in Three.js. However, the 'default' value of undefined for non-raw shaders is incorrect and the cause of these warnings.

Looking at the Three.js source, it's clear the default value is null (ShaderMaterial.js#L53). Changing this resolves the issue.

Changes proposed:

  • Change default glslVersion value from undefined to null matching Three.js default

@dmarcos
Copy link
Member

dmarcos commented Nov 17, 2023

Thanks so much!

@dmarcos dmarcos merged commit 130156c into aframevr:master Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants