Skip to content

Conversation

@mrxz
Copy link
Contributor

@mrxz mrxz commented Jul 23, 2023

Description:
Tested some tooling I'm working on and found several small issues with the various examples in this repository. This PR addresses them.

Changes proposed:

  • Removed the "flythrough" boilerplate. It referenced a non-existing image, used an invalid "thickness" property of <a-box> and wasn't listed in the main examples index.html
  • Updated anime-UI to use the core hide-on-enter-ar component and (re)enabled AR button.
  • Ensure <a-mixin> is always properly closed with an end tag (it isn't a void element)
  • Fix various small typos, invalid values and delimiters

@dmarcos
Copy link
Member

dmarcos commented Jul 24, 2023

Thank you!

@dmarcos dmarcos merged commit 76904ca into aframevr:master Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants