Skip to content

A more robust fix that doesn't depend on hardcoded indices #5340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 20, 2023
Merged

A more robust fix that doesn't depend on hardcoded indices #5340

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
35a0594
A more robust fix that doesn't depend on hardcoded indices
diarmidmackenzie Jul 19, 2023
cc3c2d3
ES6 not allowed in A-Frame.
diarmidmackenzie Jul 19, 2023
9fe20f9
No single letter variables
diarmidmackenzie Jul 19, 2023
f3be0af
nit - early return
dmarcos Jul 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
nit - early return
  • Loading branch information
@dmarcos
dmarcos authored Jul 20, 2023
commit f3be0afc3a031d9219a1ebcdd72677b0839c94f9
5 changes: 2 additions & 3 deletions src/components/hand-controls.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,9 +205,8 @@ module.exports.Component = registerComponent('hand-controls', {
self.clips = gltf.animations;
el.setObject3D('mesh', mesh);
mesh.traverse(function (object) {
if (object.isMesh) {
object.material.color = new THREE.Color(handColor);
}
if (!object.isMesh) { return; }
object.material.color = new THREE.Color(handColor);
});
mesh.position.set(0, 0, 0);
mesh.rotation.set(handModelOrientationX, 0, handModelOrientationZ);
Expand Down