-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
add default for dracoDecoderPath #5156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
latest versioned release: https://github.com/google/draco#version-155-release
|
re: meshopt. I guess we can include if it doesn't have any overhead like the draco decoder |
|
I see some tests failing |
|
the test failing doesn't seem to be related to committed code, instead firefox not launching. I'll try closing / reopening to retrigger the test |
|
If no overhead we can also include |
|
Yes, looks like |
|
When including I'm not sure how to fix. I would suggest to revert this to include default path for draco only unless @dmarcos or @donmccurdy you have any additional insight. FAILED TESTS: gltf-model ✖ "after each" hook for "attaches animation clips to model" |
This reverts commit aaca279.
|
I have reverted these changes. It looks like loading meshopt has side effects. Unlike draco loader, meshopt is loaded upon system init by injecting a script element in the document. including meshopt as default should probably be tackled as a separate issue |
Yeah. I agree thanks so much! |
Description:
adds draco decoder default and a sample test scene
latest versioned release: https://github.com/google/draco#version-155-release
Changes proposed:
should we include meshopt default?