Skip to content

Bug fixes for WebXR layers: #4991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 24, 2022
Merged

Bug fixes for WebXR layers: #4991

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa1c967
Bug fixes for WebXR layers:
snagy Jan 13, 2022
9dd8983
Alternative logic to prevent loadCubeMapImages execution with a quad …
dmarcos Jan 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/components/layer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ module.exports.Component = registerComponent('layer', {
},

loadCubeMapImages: function () {
var type = this.data.type;
var glayer;
var xrGLFactory = this.xrGLFactory;
var frame = this.el.sceneEl.frame;
Expand All @@ -73,7 +72,7 @@ module.exports.Component = registerComponent('layer', {
this.loadingScreen = false;
}

if (type === 'monocubemap') {
if (this.layer.layout === 'mono') {
glayer = xrGLFactory.getSubImage(this.layer, frame);
this.loadCubeMapImage(glayer.colorTexture, src, 0);
} else {
Expand Down Expand Up @@ -245,6 +244,7 @@ module.exports.Component = registerComponent('layer', {
height: this.data.height / 2 || this.texture.image.height / 1000,
width: this.data.width / 2 || this.texture.image.width / 1000
});
this.initLoadingScreenImages();
sceneEl.renderer.xr.addLayer(this.layer);
},

Expand Down Expand Up @@ -359,7 +359,7 @@ module.exports.Component = registerComponent('layer', {
warn('The layer component requires WebXR and the layers API enabled');
return;
}
xrSession.requestReferenceSpace('local').then(this.onRequestedReferenceSpace);
xrSession.requestReferenceSpace('local-floor').then(this.onRequestedReferenceSpace);
this.needsRedraw = true;
this.layerEnabled = true;
if (this.quadPanelEl) {
Expand Down