Skip to content

Improve pinching accuracy (fixes #4689) #4691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 5, 2020
Merged

Improve pinching accuracy (fixes #4689) #4691

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f63aef4
Make pinch distance configurable; Update default pinch distance
cesmoak Sep 30, 2020
74ff24c
Adjust pinch gesture event position
cesmoak Sep 30, 2020
d48d92b
Remove configurable pinch distance properties
cesmoak Oct 3, 2020
cd0e7a2
Extract pinch gesture constants
cesmoak Oct 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove configurable pinch distance properties
  • Loading branch information
@cesmoak
cesmoak committed Oct 3, 2020
commit d48d92b0157332f2f86b2aed6d553df42509d733
2 changes: 0 additions & 2 deletions docs/components/hand-tracking-controls.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,6 @@ Use `hand-tracking-controls` to integrate [hand tracked input][webxrhandinput] i
| hand | The hand that will be tracked (i.e., right, left). | left |
| modelColor | Color of hand material. | white |
| modelStyle | Mesh representing the hand or dots matching the joints | mesh
| startPinchDistance | Maximum distance between tip of thumb and index finger before a pinch gesture is started. | 0.015 |
| endPinchDistance | Minimum distance between tip of thumb and index finger before a pinch gesture is ended. | 0.03 |

## Events

Expand Down
8 changes: 3 additions & 5 deletions src/components/hand-tracking-controls.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,7 @@ module.exports.Component = registerComponent('hand-tracking-controls', {
schema: {
hand: {default: 'right', oneOf: ['left', 'right']},
modelStyle: {default: 'mesh', oneOf: ['dots', 'mesh']},
modelColor: {default: 'white'},
startPinchDistance: {default: 0.015},
endPinchDistance: {default: 0.03}
modelColor: {default: 'white'}
},

bindMethods: function () {
Expand Down Expand Up @@ -219,14 +217,14 @@ module.exports.Component = registerComponent('hand-tracking-controls', {

var distance = indexTipPosition.distanceTo(thumbTipPosition);

if (distance < this.data.startPinchDistance && this.isPinched === false) {
if (distance < 0.015 && this.isPinched === false) {
Copy link
Member

@dmarcos dmarcos Oct 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can maybe move this to a variable at the top var PINCH_DISTANCE = 0.015 . We use similar pattern in other components

Copy link
Contributor Author

@cesmoak cesmoak Oct 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in the latest commit

this.isPinched = true;
this.pinchEventDetail.position.copy(indexTipPosition).lerp(thumbTipPosition, 0.5);
Copy link
Member

@dmarcos dmarcos Oct 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the 0.5 value for? Maybe define another variable on top?

this.pinchEventDetail.position.y += 1.5;
this.el.emit('pinchstarted', this.pinchEventDetail);
}

if (distance > this.data.endPinchDistance && this.isPinched === true) {
if (distance > 0.03 && this.isPinched === true) {
this.isPinched = false;
this.pinchEventDetail.position.copy(indexTipPosition).lerp(thumbTipPosition, 0.5);
this.pinchEventDetail.position.y += 1.5;
Expand Down