-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Migrate hand model to glTF. Old JSONLoader has been deprecated from latest THREE #3932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Missing triangles problem is now solved with a new model. |
|
Why include LegacyJSONLoader? I don't see it used here. I tested the grip animation (just in my viewer) and |
|
@donmccurdy the LegacyJSONLoader is needed to load the examples terrain (updated PR). We should convert to glTF too. I prioritized the hands model that is used by A-Frame core and consolidate all its assets to glTF. Closing hand animation for example does not play in reverse. The hand animate as expected when closing but pops up open without transition. I'm testing on Firefox / Oculus Rift. What's your setup? |
|
I just played the animation forward and backward by loading it in and using dev tools to play it, didn't check on a device yet. The branch of threejs should have this patch, right? mrdoob/three.js#14550 Also the new call to |
| if (!mesh) { return; } | ||
|
|
||
| // Stop all current animations. | ||
| mesh.mixer.stopAllAction(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks like it would break the reverse animation?
|
Fixed the remaining animation issue. This is ready to go. |

I added the glTF version of the hand models to the assets repo. Everything works as expected but two remaining quirks:
After figuring out those details this can merge.