animation component, removes <a-animation> (#1927) #3678
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngokevin
force-pushed
the
animation
branch
3 times, most recently
from
10cab03 to
88ca2a8
Compare
ngokevin
changed the title
|
This is ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
See #1927
Shortcut link to animation.js source.
Shortcut link to new animation docs
Changes proposed:
<a-animation>. Home of old<a-animation>at https://github.com/ngokevin/a-animation for people that want to temporarily use it.Performance:
15FPS vs 43FPS with large memory savings
a-animation
15FPS, lots of memory consumption due to parsing, going through
.setAttribute.Animation component
43FPS, little memory consumption from animations, leveraging ability to do direct value animations.
TODO:
Later, move core mixin code from ANode to AEntity.