Sync rotation/position with Object3D #3245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmarcos
force-pushed
the
object3Dmanipulation
branch
from
846b01b to
5cf51b7
Compare
ngokevin
reviewed
Nov 21, 2017
src/core/a-entity.js
Outdated
| var component = this.components[attr]; | ||
| var component; | ||
| if (attr === 'position') { return this.object3D.position; } | ||
| if (attr === 'rotation') { return this.getRotation(); } |
ngokevin
reviewed
Nov 21, 2017
src/core/a-entity.js
Outdated
| this.object3D.el = this; | ||
| this.object3DMap = {}; | ||
| this.parentEl = null; | ||
| this.rotationEuler = new THREE.Euler(); |
ngokevin
reviewed
Nov 21, 2017
src/core/a-entity.js
Outdated
| var radToDeg = THREE.Math.radToDeg; | ||
| var rotation = this.object3D.rotation; | ||
| var rotationObj = this.rotationObj; | ||
| rotationObj.x = radToDeg(rotation.x); |
There was a problem hiding this comment.
not too long to have written out, consider:
this.rotationObj.x = THREE.Math.degToRad(this.object3D.rotation.x);
this.rotationObj.y = THREE.Math.degToRad(this.object3D.rotation.y)
this.rotationObj.z = THREE.Math.degToRad(this.object3D.rotation.z)There was a problem hiding this comment.
I also think this is better as a private method outside the prototype:
getRotation (rotation, target)
5cf51b7 to
348431c
Compare
One can now edit the position and rotation of the object3D directly and getAttribute and setAttribute will return consistent values.
dmarcos
force-pushed
the
object3Dmanipulation
branch
from
348431c to
2341040
Compare
|
done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.