optimize component change/initialize events #2950
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmarcos
reviewed
Aug 8, 2017
src/core/component.js
Outdated
| newData: self.data, | ||
| oldData: oldData | ||
| }, false); | ||
| this.signature = {id: this.id, name: this.name}; |
ngokevin
force-pushed
the
optimizecompevent
branch
from
6bd88b8 to
4050d0d
Compare
dmarcos
reviewed
Aug 8, 2017
| oldData: oldData | ||
| }, false); | ||
| this.throttledEmitComponentChanged = utils.throttle(function emitChange () { | ||
| el.emit('componentchanged', self.evtDetail, false); |
There was a problem hiding this comment.
we are not passing oldData anymore as detail?
There was a problem hiding this comment.
I think applications can fetch that themselves if needed? I suppose we could update the object without harm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Don't pass data/oldData into the component events, only the component signature (a one time allocation). Leave it up to the application to fetch the old/current data if needed.
Changes proposed:
componentchanged(i.e., every component instance, every 200ms).componentinitialized(including thegetDataclone).