Uncaught TypeError: Cannot read properties of undefined (reading 'originalColor')

[mikemainguy]

Description:

• A-Frame Version: 1.4.1
• Platform / Device: Oculus Quest 2
• Reproducible Code Snippet or URL: https://dev.immersiveidea.com/local
• launch that site, go into immersive mode, and hit b button on controller

local:15 Uncaught TypeError: Cannot read properties of undefined (reading 'originalColor')
at NewComponent.updateButtonModel (aframe-master.js:18543:1)
at NewComponent.updateModel (aframe-master.js:18538:1)
at module.exports.onButtonEvent (aframe-master.js:34703:1)
at AEntity.onButtonTouchEnd (aframe-master.js:18275:1)
at AEntity.nrWrapper (local:15:29524)
at AEntity.emit (aframe-master.js:25830:1)
at NewComponent.handleTouch (aframe-master.js:22514:1)
at NewComponent.handleButton (aframe-master.js:22440:1)
at NewComponent.updateButtons (aframe-master.js:22426:1)
at NewComponent.tick (aframe-master.js:22385:1)

I don't observe functional change (button events still fire and my app works), I'm not sure if there's supposed to be other things happen (my buttons and thumbsticks are all black and hard to see...IDK if I've misconfigured something or something changed when we added the button color changes....which I really like BTW.

[mikemainguy]

Actually on further investigation this appears to be the first tick after a button event handler is registered then goes away. Probably innocuous and/or because I have some debugging enabled.

[dmarcos]

I recommend creating a minimal test case to reproduce the issue with https://glitch.com/~aframe. It will be easier to investigate.

[vincentfretin]

Also see https://github.com/aframevr/aframe/pull/5103/files#diff-2ee48b207a426377ea32a1749d345fd8c9b1adbe0b9d971eccb7860e1fb41cd2R461 that introduced the new code with originalColor. Changing this.buttonMeshes[buttonName].originalColor to (buttonMeshes && buttonMeshes[buttonName] && this.buttonMeshes[buttonName].originalColor) may be enough to fix the issue, we have the condition at line 464 just below so this change make sense. Can you try the change @mikemainguy and create a PR?

[vincentfretin]

It should be fixed in #5223, if you can test @mikemainguy that would be awesome.

[Utopiah]

Same problem on the Pro