Skip to content

Conversation

@jepler
Copy link
Contributor

@jepler jepler commented Jun 14, 2023

For non-Adafruit bundles, the zip files produced during pull request CI do not contain the library's py or mpy files, because there is no way to provide an alternate package-prefix; this is currently only accepted when building releases.

This PR addresses the limitation by adding the new parameter. However, in order to build correctly, the individual libs still need to use it, similar to:

    - name: Run Build CI workflow
      uses: adafruit/workflows-circuitpython-libs/build@build-bundles-community-ci
      with:
        package-prefix: jepler_udecimal

(though after this PR is merged the workflow branch name would go back to @main)

@jepler jepler requested a review from tekktrik June 14, 2023 12:59
@tekktrik
Copy link
Member

I believe this is a duplicate of #24

@jepler
Copy link
Contributor Author

jepler commented Jun 14, 2023

ummmm you're quite right. 🥇

@jepler jepler closed this Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants