fix vectorio rotation issue #9851
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
This was a relatively small change, but it still overflowed a few of the tightest builds. I thought I could shave a little bit of space by removing a duplicated debug message, but that doesn't save anything because of the way they're set to void by default anyhow. I opted to disable vectorio for the two m4 express boards without built-in displays and disabled |
tannewt
approved these changes
Dec 2, 2024
Member
tannewt
left a comment
tannewt
left a comment
There was a problem hiding this comment.
Thank you! Good work debugging this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #8742
When the mirrored axis are applied we need to subtract one so that pixel index
0becomes index319on a display that has width of 320px without this we attempt to use index320which is out of the display bounds and ignored.Testing on a pyportal with the tft reproducer from the issue now correctly shows the green outline around all 4 sides of the display in all 4 rotations.