sdioio DOC update: DATA pins pass in list #9415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jepler
approved these changes
Jul 8, 2024
|
The doc change is correct. (technically it's a list rather than a set but that only affects the "correctness" of the PR title, not the change itself so I don't think it should block inclusion of this change) |
|
thanks! |
dhalbert
changed the title
Collaborator
|
I fixed the title :) |
|
Is it still time to change the title? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure I resolved the issue properly but when I attempted to use the example code with SDIOIO it failed, indicating the DATA pins I passed didn't have a LEN attribute. I resolved it by passing the pin within a Set which made sense to me since the parameter description indicated a sequence of pins was required.
If a Set is the right way to go, then this PR updates the example accordingly.