Skip to content

Conversation

@dhalbert
Copy link
Collaborator

@dhalbert dhalbert commented Jul 6, 2024


-- Some conditional checking for ESP32-C6 was missing.
-- Be more careful that ringbuf use in usb_serial_jtag.c is atomic. ringbuf_get() is not atomic, for instance.

I tried just leaving the USB_SERIAL_JTAG_INTR_SERIAL_OUT_RECV_PKT interrupt enabled all the time, which would have made the code simpler, but that did not work.

This may fix some other reported flakiness, not sure.

Tested by writing larger files with Thonny to an espressif_esp32c6_devkitc_1_n8. That's the only C6 board I have right now.

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sending files to esp32c6 boards fails almost 100% of the time.

2 participants